Added minimum timeout for transforms search of 10 minutes #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
=========================================
Coverage 74.80% 74.80%
- Complexity 2787 2789 +2
=========================================
Files 366 366
Lines 16422 16430 +8
Branches 2342 2343 +1
=========================================
+ Hits 12284 12291 +7
- Misses 2836 2837 +1
Partials 1302 1302 ☔ View full report in Codecov by Sentry. |
bowenlan-amzn
requested review from
bowenlan-amzn,
getsaurabh02,
lezzago,
praveensameneni,
xluo-aws,
gaobinlong,
Hailong-am,
amsiglan,
sbcd90,
eirsep,
AWSHurneyt and
jowg-amazon
as code owners
| @@ -187,7 +188,7 @@ class TransformSearchService( | |||
| val searchStart = Instant.now().epochSecond | |||
| val searchResponse = backoffPolicy.retryTransformSearch(logger, transformContext.transformLockManager) { | |||
| val pageSizeDecay = 2f.pow(retryAttempt++) | |||
| val searchRequestTimeoutInSeconds = transformContext.getMaxRequestTimeoutInSeconds() | |||
| val searchRequestTimeoutInSeconds = getCancelAfterTimeInterval(transformContext.getMaxRequestTimeoutInSeconds()) | |||
There was a problem hiding this comment.
transformContext.getMaxRequestTimeoutInSeconds here is considering the lock expiration time
We acquire a lock before start to execute transform, the search request in transform may take long and actually exceed the lock duration, then we could face 2 running transform of one job.
so you can still reuse the method from the rollup PR, then do a min() with this transformContext.getMaxRequestTimeoutInSeconds if it has a value
| init { | ||
| clusterService.clusterSettings.addSettingsUpdateConsumer(TRANSFORM_JOB_SEARCH_BACKOFF_MILLIS, TRANSFORM_JOB_SEARCH_BACKOFF_COUNT) { | ||
| millis, count -> | ||
| backoffPolicy = BackoffPolicy.constantBackoff(millis, count) | ||
| } | ||
|
|
||
| clusterService.clusterSettings.addSettingsUpdateConsumer(SEARCH_CANCEL_AFTER_TIME_INTERVAL_SETTING) { | ||
| logger.info("UPDATE SETTINGS: $it") |
| @@ -187,7 +197,8 @@ class TransformSearchService( | |||
| val searchStart = Instant.now().epochSecond | |||
| val searchResponse = backoffPolicy.retryTransformSearch(logger, transformContext.transformLockManager) { | |||
| val pageSizeDecay = 2f.pow(retryAttempt++) | |||
| val searchRequestTimeoutInSeconds = transformContext.getMaxRequestTimeoutInSeconds() | |||
| val cancelTimeoutTimeValue = TimeValue.timeValueMinutes(getCancelAfterTimeInterval(cancelAfterTimeInterval.minutes)) | |||
| val searchRequestTimeoutInSeconds = transformContext.getMaxRequestTimeoutInSeconds()?.let { min(it, cancelTimeoutTimeValue.seconds) } | |||
There was a problem hiding this comment.
Since cancelTimeoutTimeValue can be -1, I think the logic should be
First check transformContext.getMaxRequestTimeoutInSeconds(), if it's not null, just use it, if it's null, then continue to check cancelTimeoutTimeValue
|
The changes look good to me! |
jowg-amazon
previously approved these changes
Dec 12, 2023
|
@Joshua152 I missed the error in the checks, can you fix it when you got time? |
Joshua152
dismissed stale reviews from jowg-amazon and bowenlan-amzn
via
89da6f2
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
* Initial impl Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix style Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * end to end functional Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * ISM transform unit tests & integ tests Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix after core #8157 (opensearch-project#857) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Upgrade the backport workflow (opensearch-project#862) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added 2.9 release notes. (opensearch-project#851) * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Handle NPE in isRollupIndex (opensearch-project#855) * Handle NPE in isRollupIndex `metadata.index()` can return `null`, so handle that case by returning `false`. Signed-off-by: Bryce Lampe <brycelampe@gmail.com> * unit test Signed-off-by: Bryce Lampe <brycelampe@gmail.com> --------- Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix core XcontentType refactor (opensearch-project#873) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix for max & min aggregations when no metric property exist (opensearch-project#870) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * core refactor change (opensearch-project#884) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * update backport branch name (opensearch-project#885) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * core refactor change (opensearch-project#887) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix breaking change by core refactor (opensearch-project#888) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix core breaking (opensearch-project#906) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Support copy alias in rollover (opensearch-project#907) * Support copy alias in rollover Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * 2.10 Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Set preference to _primary when searching control-center index (opensearch-project#911) * Set preference to _primary when searching control-center index Signed-off-by: gaobinlong <gbinlong@amazon.com> * Use _primary_first instead Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Add primary first preference to all search requests (opensearch-project#912) Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix intelliJ IDEA gradle sync error (opensearch-project#916) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * make control center index as system index (opensearch-project#919) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Updates demo certs used in integ tests (opensearch-project#921) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added 2.10 release notes (opensearch-project#925) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Bump bwc version (opensearch-project#930) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix integ tests; upgrade mappings versions Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix DCO Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed pr comments; Add integ test case for re-execute the same transform action Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed detekt error Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added ISMTransform writeable test Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed comments; Moved updateTransformStartTime to IndexManagementRestTestCase Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> --------- Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: gaobinlong <gbl_long@163.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
…ch-project#999) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
* Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
…null (opensearch-project#967) * Refactor the policy to be non null in managed index config Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Update Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * fix bug Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
* Add more error notification at fail points Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Handle exception gracefully Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * small fix Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
…oject#1007) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
…ation (opensearch-project#1014) Signed-off-by: n-dohrmann <noah@dohrmann.org> Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
…ect#1025) * Onboard jenkins prod docker images to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Co-authored-by: ikibo <oleg.kravchuk@logz.io> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
* tester code: pipeline aggr. transform job Signed-off-by: n-dohrmann <noah@dohrmann.org> * made test case for pipeline aggregator in transform job Signed-off-by: n-dohrmann <noah@dohrmann.org> * removed unnec. test lines Signed-off-by: n-dohrmann <noah@dohrmann.org> * re-added method call on Transform obj Signed-off-by: n-dohrmann <noah@dohrmann.org> --------- Signed-off-by: n-dohrmann <noah@dohrmann.org> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
* Added unit test for switchAliases method. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * Added unit test for switchAliases method checking the flow when switchAliases is disabled. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> --------- Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
… set it to the current time of request execution. (opensearch-project#1036) Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
…ps (opensearch-project#1026) * Added minimum for search.cancel_after_time_interval setting for rollups Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added constant for cancel_after_time_interval for rollup search Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Handled case of default value for cancel interval Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added comment explanation for default rollup cancel after time interval Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed github workflow checks Signed-off-by: Joshua Au <joshuahyau@gmail.com> --------- Signed-off-by: Joshua Au <joshuahyau@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
opensearch-project#1040) * Interval schedule should take start time from the request, should not set it to the current time of request execution. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * Changed the "delayed continuous execution test" to be more expressive about what it should test. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed the NPE if schedule.startTime is NULL Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed the NPE if schedule.startTime is NULL Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed styling Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * - removed null checks from RollUp and Transforms - fixed comments in the "delayed execution" test Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> --------- Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Signed-off-by: Joshua Au <joshuahyau@gmail.com>
Joshua152
force-pushed
the
issue710-transform
branch
from
89da6f2
to
4414a2a
Compare
bowenlan-amzn
approved these changes
Dec 12, 2023
jowg-amazon
approved these changes
Dec 12, 2023
bowenlan-amzn
merged commit 60a8513
into
opensearch-project:main
23 of 25 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Added minimum timeout for transforms search of 10 minutes Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Extracted cancel minimum code to function Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed transform code to use cluster setting Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed log statements Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Changed timeout logic Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Switched to basing off seconds Signed-off-by: Joshua Au <joshuahyau@gmail.com> * [Feature] Support Transform as an ISM action (#760) * Initial impl Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix style Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * end to end functional Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * ISM transform unit tests & integ tests Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix after core #8157 (#857) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Upgrade the backport workflow (#862) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added 2.9 release notes. (#851) * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Handle NPE in isRollupIndex (#855) * Handle NPE in isRollupIndex `metadata.index()` can return `null`, so handle that case by returning `false`. Signed-off-by: Bryce Lampe <brycelampe@gmail.com> * unit test Signed-off-by: Bryce Lampe <brycelampe@gmail.com> --------- Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix core XcontentType refactor (#873) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix for max & min aggregations when no metric property exist (#870) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * core refactor change (#884) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * update backport branch name (#885) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * core refactor change (#887) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix breaking change by core refactor (#888) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix core breaking (#906) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Support copy alias in rollover (#907) * Support copy alias in rollover Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * 2.10 Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Set preference to _primary when searching control-center index (#911) * Set preference to _primary when searching control-center index Signed-off-by: gaobinlong <gbinlong@amazon.com> * Use _primary_first instead Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Add primary first preference to all search requests (#912) Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix intelliJ IDEA gradle sync error (#916) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * make control center index as system index (#919) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Updates demo certs used in integ tests (#921) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added 2.10 release notes (#925) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Bump bwc version (#930) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix integ tests; upgrade mappings versions Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix DCO Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed pr comments; Add integ test case for re-execute the same transform action Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed detekt error Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added ISMTransform writeable test Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed comments; Moved updateTransformStartTime to IndexManagementRestTestCase Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> --------- Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: gaobinlong <gbl_long@163.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * [Test] increase the wait time after transform job triggered (#999) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Drafted 2.11 release notes. (#1004) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Refactor change policy API and the policy in managed index to be non-null (#967) * Refactor the policy to be non null in managed index config Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Update Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * fix bug Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Add more error notification at fail points (#1000) * Add more error notification at fail points Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Handle exception gracefully Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * small fix Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * fix the race condition in test reset action start time (#1007) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Bump bwc version after 2.11 release (#1015) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * added type check for pipeline aggregator types in Transform initialization (#1014) Signed-off-by: n-dohrmann <noah@dohrmann.org> Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Improve security plugin enabling check (#1017) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Onboard jenkins prod docker images to github actions (#1025) * Onboard jenkins prod docker images to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Support switch aliases in shrink action. (#987) Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Co-authored-by: ikibo <oleg.kravchuk@logz.io> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Transform pipeline aggr test (#1027) * tester code: pipeline aggr. transform job Signed-off-by: n-dohrmann <noah@dohrmann.org> * made test case for pipeline aggregator in transform job Signed-off-by: n-dohrmann <noah@dohrmann.org> * removed unnec. test lines Signed-off-by: n-dohrmann <noah@dohrmann.org> * re-added method call on Transform obj Signed-off-by: n-dohrmann <noah@dohrmann.org> --------- Signed-off-by: n-dohrmann <noah@dohrmann.org> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added unit test for switchAliases method. (#1035) * Added unit test for switchAliases method. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * Added unit test for switchAliases method checking the flow when switchAliases is disabled. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> --------- Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Interval schedule should take start time from the request, should not set it to the current time of request execution. (#1036) Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added minimum for search.cancel_after_time_interval setting for rollups (#1026) * Added minimum for search.cancel_after_time_interval setting for rollups Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added constant for cancel_after_time_interval for rollup search Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Handled case of default value for cancel interval Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added comment explanation for default rollup cancel after time interval Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed github workflow checks Signed-off-by: Joshua Au <joshuahyau@gmail.com> --------- Signed-off-by: Joshua Au <joshuahyau@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Update 2.11.1 release note (#1042) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Interval schedule should take start time from the request, should not… (#1040) * Interval schedule should take start time from the request, should not set it to the current time of request execution. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * Changed the "delayed continuous execution test" to be more expressive about what it should test. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed the NPE if schedule.startTime is NULL Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed the NPE if schedule.startTime is NULL Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed styling Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * - removed null checks from RollUp and Transforms - fixed comments in the "delayed execution" test Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> --------- Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed unused imports Signed-off-by: Joshua Au <joshuahyau@gmail.com> --------- Signed-off-by: Joshua Au <joshuahyau@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: n-dohrmann <noah@dohrmann.org> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Co-authored-by: Tanqiu Liu <liutanqiu@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: gaobinlong <gbl_long@163.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: n-dohrmann <87952011+n-dohrmann@users.noreply.github.com> Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Co-authored-by: ikibo <oleg.kravchuk@logz.io> (cherry picked from commit 60a8513) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon
added a commit
that referenced
this pull request
Dec 12, 2023
) * Added minimum timeout for transforms search of 10 minutes * Extracted cancel minimum code to function * Fixed transform code to use cluster setting * Removed log statements * Changed timeout logic * Switched to basing off seconds * [Feature] Support Transform as an ISM action (#760) * Initial impl * fix style * end to end functional * ISM transform unit tests & integ tests * Fix after core #8157 (#857) * Upgrade the backport workflow (#862) * Added 2.9 release notes. (#851) * Added 2.9 release notes. * Added 2.9 release notes. * Added 2.9 release notes. --------- * Handle NPE in isRollupIndex (#855) * Handle NPE in isRollupIndex `metadata.index()` can return `null`, so handle that case by returning `false`. * unit test --------- * Fix core XcontentType refactor (#873) * fix for max & min aggregations when no metric property exist (#870) * core refactor change (#884) * update backport branch name (#885) * core refactor change (#887) * Fix breaking change by core refactor (#888) * fix core breaking (#906) * Support copy alias in rollover (#907) * Support copy alias in rollover * 2.10 --------- * Set preference to _primary when searching control-center index (#911) * Set preference to _primary when searching control-center index * Use _primary_first instead --------- * Add primary first preference to all search requests (#912) * fix intelliJ IDEA gradle sync error (#916) * make control center index as system index (#919) * Updates demo certs used in integ tests (#921) * Added 2.10 release notes (#925) * Bump bwc version (#930) * fix integ tests; upgrade mappings versions * Fix DCO * Addressed pr comments; Add integ test case for re-execute the same transform action * Addressed detekt error * Added ISMTransform writeable test * Addressed comments; Moved updateTransformStartTime to IndexManagementRestTestCase --------- * [Test] increase the wait time after transform job triggered (#999) * Drafted 2.11 release notes. (#1004) * Drafted 2.11 release notes. * Drafted 2.11 release notes. --------- * Refactor change policy API and the policy in managed index to be non-null (#967) * Refactor the policy to be non null in managed index config * Update * fix bug --------- * Add more error notification at fail points (#1000) * Add more error notification at fail points * Handle exception gracefully * small fix --------- * fix the race condition in test reset action start time (#1007) * Bump bwc version after 2.11 release (#1015) * added type check for pipeline aggregator types in Transform initialization (#1014) * Improve security plugin enabling check (#1017) * Onboard jenkins prod docker images to github actions (#1025) * Onboard jenkins prod docker images to github actions * Add more * Add more --------- * Support switch aliases in shrink action. (#987) * Transform pipeline aggr test (#1027) * tester code: pipeline aggr. transform job * made test case for pipeline aggregator in transform job * removed unnec. test lines * re-added method call on Transform obj --------- * Added unit test for switchAliases method. (#1035) * Added unit test for switchAliases method. * Added unit test for switchAliases method checking the flow when switchAliases is disabled. --------- * Interval schedule should take start time from the request, should not set it to the current time of request execution. (#1036) * Added minimum for search.cancel_after_time_interval setting for rollups (#1026) * Added minimum for search.cancel_after_time_interval setting for rollups * Added constant for cancel_after_time_interval for rollup search * Handled case of default value for cancel interval * Added comment explanation for default rollup cancel after time interval * Fixed github workflow checks --------- * Update 2.11.1 release note (#1042) * Interval schedule should take start time from the request, should not… (#1040) * Interval schedule should take start time from the request, should not set it to the current time of request execution. * Changed the "delayed continuous execution test" to be more expressive about what it should test. * fixed the NPE if schedule.startTime is NULL * fixed the NPE if schedule.startTime is NULL * fixed styling * - removed null checks from RollUp and Transforms - fixed comments in the "delayed execution" test --------- * Removed unused imports --------- (cherry picked from commit 60a8513) Signed-off-by: Joshua Au <joshuahyau@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: n-dohrmann <noah@dohrmann.org> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Tanqiu Liu <liutanqiu@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: gaobinlong <gbl_long@163.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: n-dohrmann <87952011+n-dohrmann@users.noreply.github.com> Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Co-authored-by: ikibo <oleg.kravchuk@logz.io>
Joshua152
added a commit
to Joshua152/index-management
that referenced
this pull request
Dec 22, 2023
…-project#1033) * Added minimum timeout for transforms search of 10 minutes Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Extracted cancel minimum code to function Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed transform code to use cluster setting Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed log statements Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Changed timeout logic Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Switched to basing off seconds Signed-off-by: Joshua Au <joshuahyau@gmail.com> * [Feature] Support Transform as an ISM action (opensearch-project#760) * Initial impl Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix style Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * end to end functional Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * ISM transform unit tests & integ tests Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix after core #8157 (opensearch-project#857) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Upgrade the backport workflow (opensearch-project#862) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added 2.9 release notes. (opensearch-project#851) * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Added 2.9 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Handle NPE in isRollupIndex (opensearch-project#855) * Handle NPE in isRollupIndex `metadata.index()` can return `null`, so handle that case by returning `false`. Signed-off-by: Bryce Lampe <brycelampe@gmail.com> * unit test Signed-off-by: Bryce Lampe <brycelampe@gmail.com> --------- Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix core XcontentType refactor (opensearch-project#873) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix for max & min aggregations when no metric property exist (opensearch-project#870) Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * core refactor change (opensearch-project#884) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * update backport branch name (opensearch-project#885) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * core refactor change (opensearch-project#887) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix breaking change by core refactor (opensearch-project#888) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix core breaking (opensearch-project#906) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Support copy alias in rollover (opensearch-project#907) * Support copy alias in rollover Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * 2.10 Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Set preference to _primary when searching control-center index (opensearch-project#911) * Set preference to _primary when searching control-center index Signed-off-by: gaobinlong <gbinlong@amazon.com> * Use _primary_first instead Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Add primary first preference to all search requests (opensearch-project#912) Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix intelliJ IDEA gradle sync error (opensearch-project#916) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * make control center index as system index (opensearch-project#919) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Updates demo certs used in integ tests (opensearch-project#921) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added 2.10 release notes (opensearch-project#925) Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Bump bwc version (opensearch-project#930) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * fix integ tests; upgrade mappings versions Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Fix DCO Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed pr comments; Add integ test case for re-execute the same transform action Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed detekt error Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Added ISMTransform writeable test Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> * Addressed comments; Moved updateTransformStartTime to IndexManagementRestTestCase Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> --------- Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: gaobinlong <gbl_long@163.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * [Test] increase the wait time after transform job triggered (opensearch-project#999) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Drafted 2.11 release notes. (opensearch-project#1004) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <hurneyt@amazon.com> --------- Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Refactor change policy API and the policy in managed index to be non-null (opensearch-project#967) * Refactor the policy to be non null in managed index config Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Update Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * fix bug Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Add more error notification at fail points (opensearch-project#1000) * Add more error notification at fail points Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * Handle exception gracefully Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> * small fix Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> --------- Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * fix the race condition in test reset action start time (opensearch-project#1007) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Bump bwc version after 2.11 release (opensearch-project#1015) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * added type check for pipeline aggregator types in Transform initialization (opensearch-project#1014) Signed-off-by: n-dohrmann <noah@dohrmann.org> Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Improve security plugin enabling check (opensearch-project#1017) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Onboard jenkins prod docker images to github actions (opensearch-project#1025) * Onboard jenkins prod docker images to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Support switch aliases in shrink action. (opensearch-project#987) Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Co-authored-by: ikibo <oleg.kravchuk@logz.io> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Transform pipeline aggr test (opensearch-project#1027) * tester code: pipeline aggr. transform job Signed-off-by: n-dohrmann <noah@dohrmann.org> * made test case for pipeline aggregator in transform job Signed-off-by: n-dohrmann <noah@dohrmann.org> * removed unnec. test lines Signed-off-by: n-dohrmann <noah@dohrmann.org> * re-added method call on Transform obj Signed-off-by: n-dohrmann <noah@dohrmann.org> --------- Signed-off-by: n-dohrmann <noah@dohrmann.org> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added unit test for switchAliases method. (opensearch-project#1035) * Added unit test for switchAliases method. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * Added unit test for switchAliases method checking the flow when switchAliases is disabled. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> --------- Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Interval schedule should take start time from the request, should not set it to the current time of request execution. (opensearch-project#1036) Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added minimum for search.cancel_after_time_interval setting for rollups (opensearch-project#1026) * Added minimum for search.cancel_after_time_interval setting for rollups Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added constant for cancel_after_time_interval for rollup search Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Handled case of default value for cancel interval Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Added comment explanation for default rollup cancel after time interval Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Fixed github workflow checks Signed-off-by: Joshua Au <joshuahyau@gmail.com> --------- Signed-off-by: Joshua Au <joshuahyau@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Update 2.11.1 release note (opensearch-project#1042) Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Interval schedule should take start time from the request, should not… (opensearch-project#1040) * Interval schedule should take start time from the request, should not set it to the current time of request execution. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * Changed the "delayed continuous execution test" to be more expressive about what it should test. Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed the NPE if schedule.startTime is NULL Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed the NPE if schedule.startTime is NULL Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * fixed styling Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> * - removed null checks from RollUp and Transforms - fixed comments in the "delayed execution" test Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> --------- Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Signed-off-by: Joshua Au <joshuahyau@gmail.com> * Removed unused imports Signed-off-by: Joshua Au <joshuahyau@gmail.com> --------- Signed-off-by: Joshua Au <joshuahyau@gmail.com> Signed-off-by: Tanqiu Liu <liutanqiu@gmail.com> Signed-off-by: bowenlan-amzn <bowenlan23@gmail.com> Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Signed-off-by: AWSHurneyt <hurneyt@amazon.com> Signed-off-by: Bryce Lampe <brycelampe@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Subhobrata Dey <sbcd90@gmail.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: n-dohrmann <noah@dohrmann.org> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Co-authored-by: Tanqiu Liu <liutanqiu@gmail.com> Co-authored-by: bowenlan-amzn <bowenlan23@gmail.com> Co-authored-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: AWSHurneyt <hurneyt@amazon.com> Co-authored-by: Bryce Lampe <brycelampe@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Subhobrata Dey <sbcd90@gmail.com> Co-authored-by: gaobinlong <gbl_long@163.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: n-dohrmann <87952011+n-dohrmann@users.noreply.github.com> Co-authored-by: Joanne Wang <109310487+jowg-amazon@users.noreply.github.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Oleg Kravchuk <oleg.ikibo@gmail.com> Co-authored-by: ikibo <oleg.kravchuk@logz.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #710
Description of changes:
Added a minimum cancel after timeout to the transform search service. The minimum is set to 10 minutes and is applied either when the request timeout is less than 10 minutes or the request timeout is null.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.